[Scons-users] MSVC 14.2 (Visual Studio 2019) detected as 14.1

[Leonard de Ruijter Development]

Hello all,


For NVDA, a screen reader for the visually impaired, we're using SCons as build system. In our sconstruct file, we enforce the use of Visual Studio 2017, like this:


if not env.get('MSVC_VERSION')=='14.1':
    raise RuntimeError("Visual C++ 14.1 (Visual Studio 2017) not found")


With Visual Studio 2019 however, I noticed that the build still ran. After investigation, I noticed that the MSVC_VERSION variable was set to 14.1.


I also tried the following:


>>> from SCons.Tool.MSCommon.vc import find_vc_pdir
>>> find_vc_pdir("14.1")
u'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC'
>>> find_vc_pdir("14.2")
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "D:\Development\nvda\include\scons\src\engine\SCons\Tool\MSCommon\vc.py", line 338, in find_vc_pdir
    raise UnsupportedVersion("Unknown version %s" % msvc_version)
UnsupportedVersion: Unknown version 14.2

This is with Python 2.7.16 with SCons master.

It would be great if VC14.2 support could be added properly.


Regards,

Leonard de Ruijter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20190410/c2f96264/attachment.html>