[Scons-users] MSVC 14.2 (Visual Studio 2019) detected as 14.1

[Bill Deegan]

Leonard,

We're aware of the issue.
We're working on VS2019 support. (Currently not supported)
Hopefully have something before too long.

As far as adding support "properly".. It's open source.
If you check the release notes you'll see NO indication that VS 2019 is
supported as yet.

If you'd like to send a pull request with a fix, that's always welcome.

-Bill
P.S. Thank you or working on such a project. My mother-in-law is legally
blind and working with her on the computer has made me acutely aware of how
challenging it is for her.
P.P.S See that's how you thank open source developers for their time and
effort.. ;)

On Wed, Apr 10, 2019 at 9:35 AM Leonard de Ruijter Development <
dev at systeemdenker.nl> wrote:

> Hello all,
>
>
> For NVDA, a screen reader for the visually impaired, we're using SCons as
> build system. In our sconstruct file, we enforce the use of Visual Studio
> 2017, like this:
>
>
> if not env.get('MSVC_VERSION')=='14.1':
>     raise RuntimeError("Visual C++ 14.1 (Visual Studio 2017) not found")
>
>
> With Visual Studio 2019 however, I noticed that the build still ran. After
> investigation, I noticed that the MSVC_VERSION variable was set to 14.1.
>
>
> I also tried the following:
>
>
> >>> from SCons.Tool.MSCommon.vc import find_vc_pdir
> >>> find_vc_pdir("14.1")
> u'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC'
> >>> find_vc_pdir("14.2")
> Traceback (most recent call last):
>   File "<console>", line 1, in <module>
>   File
> "D:\Development\nvda\include\scons\src\engine\SCons\Tool\MSCommon\vc.py",
> line 338, in find_vc_pdir
>     raise UnsupportedVersion("Unknown version %s" % msvc_version)
> UnsupportedVersion: Unknown version 14.2
>
> This is with Python 2.7.16 with SCons master.
>
> It would be great if VC14.2 support could be added properly.
>
>
> Regards,
>
> Leonard de Ruijter
> _______________________________________________
> Scons-users mailing list
> Scons-users at scons.org
> https://pairlist4.pair.net/mailman/listinfo/scons-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20190410/28ca69be/attachment.html>